The following document contains the results of Checkstyle. 
| Files | Infos |
Warnings |
Errors |
|---|---|---|---|
| 23 | 0 | 312 | 0 |
| Rules | Violations | Severity |
|---|---|---|
JavadocMethod
|
34 | |
| JavadocStyle | 64 | |
| JavadocType | 0 | |
| MissingDeprecated | 0 | |
| MissingOverride | 6 | |
| ConstantName | 2 | |
| LocalFinalVariableName | 0 | |
| LocalVariableName | 0 | |
| MemberName | 0 | |
| MethodName | 13 | |
| PackageName | 0 | |
| MethodTypeParameterName | 0 | |
| StaticVariableName | 0 | |
| PackageName | 0 | |
| ParameterName | 0 | |
| TypeName | 0 | |
| AvoidStarImport | 0 | |
| IllegalImport | 0 | |
| RedundantImport | 0 | |
| UnusedImports | 35 | |
LineLength
|
31 | |
| EmptyForIteratorPad | 0 | |
| GenericWhitespace | 0 | |
| ModifierOrder | 0 | |
| RedundantModifier | 0 | |
| AvoidNestedBlocks | 0 | |
| EmptyBlock | 2 | |
LeftCurly
|
0 | |
| NeedBraces | 2 | |
| AvoidInlineConditionals | 0 | |
| DoubleCheckedLocking | 0 | |
| EmptyStatement | 0 | |
| EqualsHashCode | 0 | |
| HiddenField | 37 | |
| IllegalInstantiation | 0 | |
| InnerAssignment | 0 | |
| MagicNumber | 4 | |
| MissingSwitchDefault | 0 | |
RedundantThrows
|
0 | |
| SimplifyBooleanExpression | 0 | |
| SimplifyBooleanReturn | 0 | |
| StringLiteralEquality | 0 | |
| FinalLocalVariable | 8 | |
| FinalClass | 0 | |
| HideUtilityClassConstructor | 0 | |
| VisibilityModifier | 5 | |
| MutableException | 0 | |
| InterfaceIsType | 0 | |
| ArrayTypeStyle | 0 | |
| FinalParameters | 69 | |
| TodoComment | 0 | |
| UpperEll | 0 | |
CyclomaticComplexity
|
0 | |
BooleanExpressionComplexity
|
0 | |
| FallThrough | 0 | |
| ParameterAssignment | 0 | |
| SuperFinalize | 0 | |
| SuperClone | 0 | |
| ClassFanOutComplexity | 0 | |
| FileTabCharacter | 0 |
| Violation | Message | Line |
|---|---|---|
| Unused import - java.util.Collections. | 7 | |
| Unused import - java.util.Set. | 8 | |
| Unused import - java.util.HashSet. | 9 | |
| Unused import - org.mod4j.runtime.validation.MinValueValidator. | 10 | |
| Unused import - org.mod4j.runtime.validation.MaxValueValidator. | 11 | |
| Unused import - org.mod4j.runtime.validation.MinLengthValidator. | 12 | |
| Unused import - org.mod4j.runtime.validation.MaxLengthValidator. | 13 | |
| Unused import - org.mod4j.runtime.validation.RegExpValidator. | 14 | |
| First sentence should end with a period. | 16 | |
| First sentence should end with a period. | 25 | |
| First sentence should end with a period. | 30 | |
| First sentence should end with a period. | 37 | |
| Parameter firstName should be final. | 47 | |
| Parameter lastName should be final. | 47 | |
| Parameter title should be final. | 47 | |
| 'title' hides a field. | 47 | |
| 'title' hides a field. | 67 | |
| Line is longer than 100 characters. | 73 | |
| Parameter value should be final. | 79 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 16 | |
| Variable 'aMap' should be declared final. | 17 | |
| Variable 'person' should be declared final. | 18 | |
| Variable 'name' should be declared final. | 23 | |
| Variable 'b' should be declared final. | 25 | |
| Must have at least one statement. | 27 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 13 | |
| First sentence should end with a period. | 20 | |
| Parameter firstName should be final. | 30 | |
| Parameter lastName should be final. | 30 | |
| Parameter customerNr should be final. | 30 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 | |
| First sentence should end with a period. | 33 | |
| First sentence should end with a period. | 42 | |
| Line is longer than 100 characters. | 47 | |
| First sentence should end with a period. | 49 | |
| First sentence should end with a period. | 54 | |
| First sentence should end with a period. | 63 | |
| First sentence should end with a period. | 75 | |
| Parameter element should be final. | 78 | |
| Expected @param tag for 'element'. | 78 | |
| First sentence should end with a period. | 95 | |
| Parameter element should be final. | 100 | |
| Expected @param tag for 'element'. | 100 | |
| Name 'z_internalAddToorders' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 116 | |
| Parameter element should be final. | 116 | |
| Expected @param tag for 'element'. | 116 | |
| Name 'z_internalRemoveFromorders' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 126 | |
| Parameter element should be final. | 126 | |
| Expected @param tag for 'element'. | 126 | |
| First sentence should end with a period. | 130 | |
| First sentence should end with a period. | 137 | |
| Parameter firstName should be final. | 147 | |
| Parameter lastName should be final. | 147 | |
| Parameter customerNr should be final. | 147 | |
| 'customerNr' hides a field. | 147 | |
| 'customerNr' hides a field. | 217 | |
| 'username' hides a field. | 226 | |
| 'emailAddress' hides a field. | 235 | |
| 'blackListed' hides a field. | 244 | |
| 'discountPercentage' hides a field. | 253 | |
| Parameter value should be final. | 265 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 10 | |
| Missing a Javadoc comment. | 16 | |
| Variable 'aMap' should be declared final. | 18 | |
| Variable 'person' should be declared final. | 19 | |
| Must have at least one statement. | 29 | |
| First sentence should end with a period. | 37 | |
| First sentence should end with a period. | 43 | |
| Parameter orderNumber should be final. | 49 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 2 | |
| Unused import - org.mod4j.runtime.validation.MinLengthValidator. | 13 | |
| Unused import - org.mod4j.runtime.validation.MaxLengthValidator. | 14 | |
| Unused import - org.mod4j.runtime.validation.RegExpValidator. | 15 | |
| Line is longer than 100 characters. | 22 | |
| Line is longer than 100 characters. | 31 | |
| Variable 'validation' must be private and have accessor methods. | 34 | |
| First sentence should end with a period. | 52 | |
| First sentence should end with a period. | 57 | |
| First sentence should end with a period. | 64 | |
| First sentence should end with a period. | 71 | |
| First sentence should end with a period. | 80 | |
| First sentence should end with a period. | 92 | |
| Parameter element should be final. | 95 | |
| Expected @param tag for 'element'. | 95 | |
| First sentence should end with a period. | 106 | |
| Parameter element should be final. | 111 | |
| Expected @param tag for 'element'. | 111 | |
| Line is longer than 100 characters. | 121 | |
| Name 'z_internalAddToorderLines' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 125 | |
| Parameter element should be final. | 125 | |
| Expected @param tag for 'element'. | 125 | |
| Line is longer than 100 characters. | 130 | |
| Name 'z_internalRemoveFromorderLines' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 134 | |
| Parameter element should be final. | 134 | |
| Expected @param tag for 'element'. | 134 | |
| First sentence should end with a period. | 140 | |
| Expected an @return tag. | 145 | |
| First sentence should end with a period. | 149 | |
| Parameter element should be final. | 154 | |
| Expected @param tag for 'element'. | 154 | |
| Line is longer than 100 characters. | 168 | |
| Name 'z_internalAddTocustomer' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 173 | |
| Parameter element should be final. | 173 | |
| Expected @param tag for 'element'. | 173 | |
| Line is longer than 100 characters. | 178 | |
| Name 'z_internalRemoveFromcustomer' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 183 | |
| Parameter element should be final. | 183 | |
| Expected @param tag for 'element'. | 183 | |
| First sentence should end with a period. | 187 | |
| First sentence should end with a period. | 194 | |
| Parameter orderNumber should be final. | 200 | |
| 'orderNumber' hides a field. | 200 | |
| Line is longer than 100 characters. | 204 | |
| Line is longer than 100 characters. | 206 | |
| 'orderNumber' hides a field. | 249 | |
| 'orderDate' hides a field. | 258 | |
| 'deliveryDateTime' hides a field. | 267 | |
| 'discountPercentage' hides a field. | 276 | |
| Line is longer than 100 characters. | 282 | |
| Parameter value should be final. | 288 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 13 | |
| First sentence should end with a period. | 20 | |
| Parameter lineNumber should be final. | 30 | |
| Parameter description should be final. | 30 | |
| Parameter lineAmount should be final. | 30 |
| Violation | Message | Line |
|---|---|---|
| Variable 'validation' must be private and have accessor methods. | 25 | |
| First sentence should end with a period. | 43 | |
| First sentence should end with a period. | 52 | |
| First sentence should end with a period. | 57 | |
| First sentence should end with a period. | 62 | |
| First sentence should end with a period. | 74 | |
| Parameter element should be final. | 77 | |
| Expected @param tag for 'element'. | 77 | |
| Name 'z_internalSetrecord' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 100 | |
| Parameter element should be final. | 100 | |
| Expected @param tag for 'element'. | 100 | |
| Name 'z_internalRemoverecord' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 110 | |
| Parameter element should be final. | 110 | |
| Expected @param tag for 'element'. | 110 | |
| First sentence should end with a period. | 114 | |
| First sentence should end with a period. | 121 | |
| Parameter lineNumber should be final. | 131 | |
| 'lineNumber' hides a field. | 131 | |
| Parameter description should be final. | 131 | |
| 'description' hides a field. | 131 | |
| Parameter lineAmount should be final. | 131 | |
| 'lineAmount' hides a field. | 131 | |
| 'lineNumber' hides a field. | 174 | |
| 'description' hides a field. | 183 | |
| 'lineAmount' hides a field. | 192 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 13 | |
| First sentence should end with a period. | 20 | |
| Parameter firstName should be final. | 28 | |
| Parameter lastName should be final. | 28 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 2 | |
| Unused import - java.util.Collections. | 8 | |
| Unused import - java.util.Set. | 9 | |
| Unused import - java.util.HashSet. | 10 | |
| Unused import - org.mod4j.runtime.validation.MinLengthValidator. | 13 | |
| Unused import - org.mod4j.runtime.validation.MaxLengthValidator. | 14 | |
| Unused import - org.mod4j.runtime.validation.RegExpValidator. | 15 | |
| Line is longer than 100 characters. | 27 | |
| Variable 'validation' must be private and have accessor methods. | 30 | |
| First sentence should end with a period. | 58 | |
| First sentence should end with a period. | 72 | |
| First sentence should end with a period. | 77 | |
| First sentence should end with a period. | 84 | |
| Parameter firstName should be final. | 92 | |
| 'firstName' hides a field. | 92 | |
| Parameter lastName should be final. | 92 | |
| 'lastName' hides a field. | 92 | |
| Line is longer than 100 characters. | 97 | |
| Line is longer than 100 characters. | 99 | |
| 'firstName' hides a field. | 148 | |
| 'lastName' hides a field. | 157 | |
| 'age' hides a field. | 166 | |
| 'numberOfEars' hides a field. | 175 | |
| 'sexe' hides a field. | 184 | |
| Line is longer than 100 characters. | 190 | |
| Parameter value should be final. | 196 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 13 | |
| First sentence should end with a period. | 20 | |
| Parameter productNumnber should be final. | 28 | |
| Parameter price should be final. | 28 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 2 | |
| Unused import - java.util.Collections. | 8 | |
| Unused import - org.mod4j.runtime.validation.MinValueValidator. | 11 | |
| Unused import - org.mod4j.runtime.validation.MaxValueValidator. | 12 | |
| Unused import - org.mod4j.runtime.validation.MinLengthValidator. | 13 | |
| Unused import - org.mod4j.runtime.validation.MaxLengthValidator. | 14 | |
| Unused import - org.mod4j.runtime.validation.RegExpValidator. | 15 | |
| Line is longer than 100 characters. | 27 | |
| Variable 'validation' must be private and have accessor methods. | 30 | |
| First sentence should end with a period. | 48 | |
| First sentence should end with a period. | 53 | |
| Missing a Javadoc comment. | 60 | |
| First sentence should end with a period. | 64 | |
| Parameter element should be final. | 69 | |
| Expected @param tag for 'element'. | 69 | |
| Missing a Javadoc comment. | 84 | |
| Parameter element should be final. | 84 | |
| Line is longer than 100 characters. | 94 | |
| Name 'z_internalAddToRecord' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 99 | |
| Parameter element should be final. | 99 | |
| Expected @param tag for 'element'. | 99 | |
| Line is longer than 100 characters. | 104 | |
| Name 'z_internalRemoveFromRecord' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 109 | |
| Parameter element should be final. | 109 | |
| Expected @param tag for 'element'. | 109 | |
| First sentence should end with a period. | 113 | |
| First sentence should end with a period. | 120 | |
| Parameter productNumnber should be final. | 128 | |
| 'productNumnber' hides a field. | 128 | |
| Parameter price should be final. | 128 | |
| 'price' hides a field. | 128 | |
| 'productNumnber' hides a field. | 156 | |
| 'price' hides a field. | 165 | |
| Line is longer than 100 characters. | 171 | |
| Parameter value should be final. | 177 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 13 | |
| First sentence should end with a period. | 20 | |
| Parameter asin should be final. | 28 | |
| Parameter price should be final. | 28 |
| Violation | Message | Line |
|---|---|---|
| Unused import - org.mod4j.runtime.validation.MinValueValidator. | 12 | |
| Unused import - org.mod4j.runtime.validation.MaxValueValidator. | 13 | |
| Unused import - org.mod4j.runtime.validation.MinLengthValidator. | 14 | |
| Unused import - org.mod4j.runtime.validation.MaxLengthValidator. | 15 | |
| Unused import - org.mod4j.runtime.validation.RegExpValidator. | 16 | |
| Variable 'validation' must be private and have accessor methods. | 32 | |
| First sentence should end with a period. | 50 | |
| First sentence should end with a period. | 55 | |
| First sentence should end with a period. | 60 | |
| '111' is a magic number. | 63 | |
| First sentence should end with a period. | 65 | |
| First sentence should end with a period. | 70 | |
| First sentence should end with a period. | 75 | |
| First sentence should end with a period. | 87 | |
| Parameter element should be final. | 90 | |
| Expected @param tag for 'element'. | 90 | |
| Name 'z_internalSetProduct' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 112 | |
| Parameter element should be final. | 112 | |
| Expected @param tag for 'element'. | 112 | |
| Name 'z_internalRemoveProduct' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 122 | |
| Parameter element should be final. | 122 | |
| Expected @param tag for 'element'. | 122 | |
| First sentence should end with a period. | 126 | |
| Parameter element should be final. | 141 | |
| Expected @param tag for 'element'. | 141 | |
| Parameter element should be final. | 149 | |
| Expected @param tag for 'element'. | 149 | |
| Parameter element should be final. | 166 | |
| Expected @param tag for 'element'. | 166 | |
| Name 'z_internalRemoveorderLine' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 190 | |
| 'asin' hides a field. | 261 | |
| 'title' hides a field. | 270 | |
| 'mediumCode' hides a field. | 279 | |
| 'price' hides a field. | 288 | |
| 'type' hides a field. | 297 | |
| Parameter value should be final. | 309 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 7 | |
| Name 'lookup' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 16 | |
| 'for' construct must use '{}'s. | 18 | |
| Missing a Javadoc comment. | 24 | |
| 'id' hides a field. | 24 | |
| Missing a Javadoc comment. | 28 | |
| Missing a Javadoc comment. | 32 | |
| Parameter id should be final. | 32 |
| Violation | Message | Line |
|---|---|---|
| Name 'lookup' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 16 | |
| 'for' construct must use '{}'s. | 18 | |
| Missing a Javadoc comment. | 24 | |
| Parameter id should be final. | 24 | |
| 'id' hides a field. | 24 | |
| Missing a Javadoc comment. | 28 | |
| Missing a Javadoc comment. | 32 | |
| Parameter id should be final. | 32 |
| Violation | Message | Line |
|---|---|---|
| Must include @java.lang.Override annotation when {@inheritDoc} Javadoc tag exists. | 20 | |
| Parameter target should be final. | 20 | |
| Parameter errors should be final. | 20 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 2 | |
| Unused import - org.springframework.validation.Errors. | 7 | |
| Unused import - org.springframework.validation.ValidationUtils. | 8 | |
| First sentence should end with a period. | 13 | |
| Must include @java.lang.Override annotation when {@inheritDoc} Javadoc tag exists. | 23 | |
| Parameter clazz should be final. | 24 |
| Violation | Message | Line |
|---|---|---|
| Must include @java.lang.Override annotation when {@inheritDoc} Javadoc tag exists. | 21 | |
| Parameter target should be final. | 21 | |
| Parameter errors should be final. | 21 | |
| Variable 'cust' should be declared final. | 23 | |
| '50' is a magic number. | 24 | |
| Line is longer than 100 characters. | 25 | |
| Line is longer than 100 characters. | 26 | |
| '50' is a magic number. | 26 | |
| Line is longer than 100 characters. | 27 | |
| '50' is a magic number. | 27 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 2 | |
| Unused import - org.springframework.validation.Errors. | 7 | |
| Unused import - org.springframework.validation.ValidationUtils. | 8 | |
| Must include @java.lang.Override annotation when {@inheritDoc} Javadoc tag exists. | 23 | |
| Parameter clazz should be final. | 24 |
| Violation | Message | Line |
|---|---|---|
| Unused import - org.joda.time.DateTime. | 8 | |
| Must include @java.lang.Override annotation when {@inheritDoc} Javadoc tag exists. | 22 | |
| Parameter target should be final. | 22 | |
| Parameter errors should be final. | 22 | |
| Variable 'order' should be declared final. | 24 | |
| Line is longer than 100 characters. | 28 | |
| Line is longer than 100 characters. | 29 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 100 characters. | 2 | |
| Unused import - org.springframework.validation.Errors. | 7 | |
| Unused import - org.springframework.validation.ValidationUtils. | 8 | |
| First sentence should end with a period. | 13 | |
| Must include @java.lang.Override annotation when {@inheritDoc} Javadoc tag exists. | 23 | |
| Parameter clazz should be final. | 24 |